snapcraft, hooks: include /usr/share/X11/XErrorDB#432
Merged
alfonsosanchezbeato merged 1 commit intocanonical:mainfrom Apr 22, 2026
Merged
snapcraft, hooks: include /usr/share/X11/XErrorDB#432alfonsosanchezbeato merged 1 commit intocanonical:mainfrom
alfonsosanchezbeato merged 1 commit intocanonical:mainfrom
Conversation
Member
alfonsosanchezbeato
left a comment
alfonsosanchezbeato
left a comment
There was a problem hiding this comment.
Please make the directory from 020-extra-files.chroot instead
bboozzoo
force-pushed
the
bboozzoo/xerrordb
branch
from
a0c0b23 to
7a7c7c2
Compare
Collaborator
Author
done |
bboozzoo
changed the title
bboozzoo
changed the title
bboozzoo
force-pushed
the
bboozzoo/xerrordb
branch
from
7a7c7c2 to
8547f8d
Compare
Comment on lines
+61
to
+64
| cat <<'EOF' > /usr/share/X11/XErrorDB | ||
| ! This is a placeholder file for bind mounting XErrorDB from GPU drivers | ||
| ! provider snap. | ||
| EOF |
Member
There was a problem hiding this comment.
Not sure if we need the file, on one side is nice but on the other hand we have plenty of mount points and we do not put files there. I think it is enough to have this as a comment in this script instead.
Collaborator
Author
There was a problem hiding this comment.
The file is the mount point, canonical/snapcraft#6188 which uses bind-file with /usr/share/X11/XErrorDB target
Member
There was a problem hiding this comment.
Got it, thanks for clarifying
Collaborator
Author
|
Per discussion with @Meulengracht we'll use chisel and ship the actual file |
bboozzoo
added
the
blocked
bboozzoo
force-pushed
the
bboozzoo/xerrordb
branch
from
8547f8d to
32b39d0
Compare
Include /usr/share/X11/XErrorDB (~42KB). This avoids needing to ship the file in the GPU drivers snap (typically mesa-2604) and setting it up in place with the help of snap layouts, which in turn would require construction of a writable mimic on top of /usr/share/X11. Signed-off-by: Maciek Borzecki <maciej.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/xerrordb
branch
from
32b39d0 to
4d1b0e5
Compare
bboozzoo
changed the title
bboozzoo
removed
the
blocked
Meulengracht
approved these changes
Apr 22, 2026
Member
Meulengracht
left a comment
Meulengracht
left a comment
There was a problem hiding this comment.
Thank you for this! Appreciate the change on direction
alfonsosanchezbeato
approved these changes
Apr 22, 2026
Member
alfonsosanchezbeato
left a comment
alfonsosanchezbeato
left a comment
There was a problem hiding this comment.
LGTM, thanks, this is indeed better
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include /usr/share/X11/XErrorDB (~42KB). This avoids needing to ship the
file in the GPU drivers snap (typically mesa-2604) and setting it up in
place with the help of snap layouts, which in turn would require
construction of a writable mimic on top of /usr/share/X11.
Related: canonical/snapcraft#6188